-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for node existing service accounts #704
Conversation
Welcome @mper0003! |
Hi @mper0003. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1567
💛 - Coveralls |
/ok-to-test |
@ayberk Test failed for some reason, would you be able to retest? |
/retest |
@@ -101,3 +101,5 @@ serviceAccount: | |||
create: true | |||
name: ebs-snapshot-controller | |||
annotations: {} | |||
node: | |||
name: "" # Name of the service-account to be used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do create, name, annotations fields instead? Although I like the brevity, we should be consistent with the other two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated to keep it consistent. Thanks
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayberk, mper0003 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
New feature
What is this PR about? / Why do we need it?
Fixes #703
What testing is done?
Helm template