Refactor e2e testing scripts to be more reusable and use them instead… #694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it? Although I do not like bash, it seems for this case it is the best tool for the job: run kops, helm, docker, awscli, etc. commands.
By comparison, I have found that the tester binary is harder to develop with (need to fork and build it to make changes since for example kops versions and args are hardcoded into it)
Plus, these scripts can be reused in EFS repo, I just have to figure out some subtree magic.
See also #473, I will continue that PR after this.
What testing is done?
In this repo:
Same scripts reusable in EFS repo: