Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix helm chart releases with "helm-chart-" #682

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jan 6, 2021

Is this a bug fix or adding new feature? fix #643

What is this PR about? / Why do we need it? Since chart version follows driver version but not really, to avoid confusion & ambiguity I want to prefix helm chart releases and tags with "helm-chart-". Open to suggestions of other names or references to best practices here.

What testing is done? tsted in my fork (took couple of tries):

https://github.com/wongma7/aws-ebs-csi-driver/runs/1658660168
https://github.com/wongma7/aws-ebs-csi-driver/releases/tag/helm-chart-aws-ebs-csi-driver-0.7.4

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2021
@ayberk
Copy link
Contributor

ayberk commented Jan 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1425

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.713%

Totals Coverage Status
Change from base Build 1424: 0.0%
Covered Lines: 1622
Relevant Lines: 1985

💛 - Coveralls

@wongma7
Copy link
Contributor Author

wongma7 commented Jan 6, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-ebs-csi-driver/682/pull-aws-ebs-csi-driver-e2e-single-az/1346913186607009792

Jan 6 20:31:07.930: INFO: Unexpected error while creating namespace: namespaces "ebs-2194" already exists

Wow, I thought the test used generateName for random namespace names?

/retest

@k8s-ci-robot k8s-ci-robot merged commit 049fc73 into kubernetes-sigs:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize helm release name
4 participants