Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use buildx in cloudbuild #658

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Use buildx in cloudbuild #658

merged 1 commit into from
Dec 15, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Dec 15, 2020

Is this a bug fix or adding new feature? fix

What is this PR about? / Why do we need it?
cloudbuild is not magic, if arm64 images are desired then buildx must b ecalled

What testing is done?
command works locally, don't have access to cloudbuild to test it in cloudbuild

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2020
wongma7
wongma7 commented Dec 15, 2020
View reviewed changes
cloudbuild.yaml Outdated
@@ -2,18 +2,26 @@ timeout: 1200s
steps:
- name: gcr.io/cloud-builders/docker
args:
- HOME=/root
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/test-infra/tree/master/config/jobs/image-pushing#simple-build-example
" # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
# set the home to /root explicitly to if using docker buildx
# - HOME=/root"

wongma7
wongma7 commented Dec 15, 2020
View reviewed changes
cloudbuild.yaml
@@ -2,18 +2,26 @@ timeout: 1200s
steps:
- name: gcr.io/cloud-builders/docker
args:
- HOME=/root
- buildx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to make command look like https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/.github/workflows/container-image.yaml#L25

ayberk
ayberk reviewed Dec 15, 2020
View reviewed changes
cloudbuild.yaml
@@ -2,18 +2,26 @@ timeout: 1200s
steps:
- name: gcr.io/cloud-builders/docker
args:
- buildx
- build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh gotcha dockerx build...

@ayberk
Copy link
Contributor

ayberk commented Dec 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020
@wongma7
Copy link
Contributor Author

wongma7 commented Dec 15, 2020

cc #656

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1382

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.713%
Totals Coverage Status
Change from base Build 1380: 0.0%
Covered Lines: 1622
Relevant Lines: 1985
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit 05a4fee into kubernetes-sigs:master Dec 15, 2020
This was referenced Dec 16, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayberk ayberk ayberk left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@ayberk ayberk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wongma7 @k8s-ci-robot @ayberk @coveralls