Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm overlay #653

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Arm overlay #653

merged 2 commits into from
Dec 11, 2020

Conversation

ayberk
Copy link
Contributor

@ayberk ayberk commented Dec 11, 2020

Is this a bug fix or adding new feature?
Maintenance

What is this PR about? / Why do we need it?
Driver can't be deployed on arm instances because of non-multiarch sidecar images. This PR updates some of the sidecar images and adds an overlay with multiarch images.

What testing is done?
Manual testing on my cluster + e2e tests.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 11, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ayberk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2020
@nckturner
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2020
@ayberk
Copy link
Contributor Author

ayberk commented Dec 11, 2020

/retest

@ayberk ayberk closed this Dec 11, 2020
@ayberk ayberk reopened this Dec 11, 2020
@ayberk
Copy link
Contributor Author

ayberk commented Dec 11, 2020

/retest continuous-integration/travis-ci/pr

@k8s-ci-robot
Copy link
Contributor

@ayberk: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test pull-aws-ebs-csi-driver-verify
  • /test pull-aws-ebs-csi-driver-unit
  • /test pull-aws-ebs-csi-driver-e2e-single-az
  • /test pull-aws-ebs-csi-driver-e2e-multi-az
  • /test pull-aws-ebs-csi-driver-migration-test-latest

Use /test all to run the following jobs:

  • pull-aws-ebs-csi-driver-verify
  • pull-aws-ebs-csi-driver-unit
  • pull-aws-ebs-csi-driver-e2e-single-az
  • pull-aws-ebs-csi-driver-e2e-multi-az

In response to this:

/retest continuous-integration/travis-ci/pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1374

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.713%
Totals Coverage Status
Change from base Build 1372: 0.0%
Covered Lines: 1622
Relevant Lines: 1985
💛 - Coveralls

wongma7
wongma7 reviewed Dec 11, 2020
View reviewed changes
charts/aws-ebs-csi-driver/templates/controller.yaml
@@ -122,7 +122,6 @@ spec:
- --csi-address=$(ADDRESS)
- --v=5
- --leader-election=true
- --leader-election-type=leases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this because the default changed to leases right? just checking

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or they removed the option an dit's leases only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah they removed it and it's leases.

wongma7
wongma7 reviewed Dec 11, 2020
View reviewed changes
charts/aws-ebs-csi-driver/templates/clusterrole-attacher.yaml
@@ -8,7 +8,7 @@ metadata:
rules:
- apiGroups: [""]
resources: ["persistentvolumes"]
verbs: ["get", "list", "watch", "update"]
verbs: ["get", "list", "watch", "update", "patch"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test the helm install /kustomize command? like if I have helm installed a prevoius version them helm install this version, i would assume that helm is smart enough to delete/recreate this object.

@wongma7
Copy link
Contributor

wongma7 commented Dec 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 14e3a46 into kubernetes-sigs:master Dec 11, 2020
@ayberk ayberk deleted the arm_overlay branch December 11, 2020 23:46
@ayberk ayberk mentioned this pull request Dec 11, 2020
Closed
@wongma7 wongma7 mentioned this pull request Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 wongma7 left review comments

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ayberk @k8s-ci-robot @nckturner @coveralls @wongma7