-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EBS gp3 support #633
Add EBS gp3 support #633
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @samjo-nyang! |
Hi @samjo-nyang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
Pull Request Test Coverage Report for Build 1333
💛 - Coveralls |
This is great, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, great work. Thank you!
We should probably change the default type to gp3 as it's cheaper and faster. What do you think @wongma7?
/ok-to-test IMO we can make gp3 the default if we release the change in a new minor version, by default the performance is equal or better, only throughput is a bit more complicated since for gp2 it might involve "burst credits" but I don't think we need to worry about it. Also there are volume type specific service quotas, so for example if a user has increased their gp2 TiB quota, they must remember to increase their gp3 one as well, but again I don't think this is worth worrying about just somethin to note. |
Thank you @samjo-nyang! /lgtm, but let's wait for one more review. One minor request, can you squash your commits? Ideally we should have one commit for updating the SDK and another one for gp3 support, but you can simply squash into one. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samjo-nyang, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Adding new feature
What is this PR about? / Why do we need it?
Support a new volume type gp3 (https://aws.amazon.com/about-aws/whats-new/2020/12/introducing-new-amazon-ebs-general-purpose-volumes-gp3/)
What testing is done?
make
succeededmake sanity-test
succeededimplements #628
However,
docker run -v "$PWD":/go -it golang:1.14.1-buster make test
triggers a lot of dependency update. Is this expected and should be in this PR? How can I update aws-sdk only?