Update hack/run-e2e-test to be more idempotent and pleasant to use #616
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ebs-e2e-test/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,151 +16,190 @@ | |
|
|
||
| set -euo pipefail | ||
|
|
||
| TEST_ID=${TEST_ID:-$RANDOM} | ||
| CLUSTER_NAME=test-cluster-${TEST_ID} | ||
|
|
||
| BASE=$(realpath "${BASH_SOURCE[0]}") | ||
| BASE_DIR=$(dirname "${BASE}") | ||
| TEST_DIR=${BASE_DIR}/ebs-e2e-test | ||
| BIN_DIR=${TEST_DIR}/bin | ||
| SSH_KEY_PATH=${TEST_DIR}/id_rsa | ||
|
|
||
| REGION=${AWS_REGION-us-west-2} | ||
| ZONES=${AWS_AVAILABILITY_ZONES:-us-west-2a,us-west-2b,us-west-2c} | ||
| INSTANCE_TYPE=${INSTANCE_TYPE:-c4.large} | ||
|
|
||
| K8S_VERSION=${K8S_VERSION:-1.18.10} | ||
| KOPS_VERSION=${KOPS_VERSION:-1.18.2} | ||
| KOPS_STATE_FILE=${KOPS_STATE_FILE:-s3://k8s-kops-csi-e2e} | ||
|
|
||
| KUBECONFIG=${KUBECONFIG:-"${HOME}/.kube/config"} | ||
| ARTIFACTS=${ARTIFACTS:-"${TEST_DIR}/artifacts"} | ||
| GINKGO_FOCUS=${GINKGO_FOCUS:-"\[ebs-csi-migration\]"} | ||
| GINKGO_SKIP=${GINKGO_SKIP:-"\[Disruptive\]"} | ||
| GINKGO_NODES=${GINKGO_NODES:-4} | ||
| CHECK_MIGRATION=${CHECK_MIGRATION:-"true"} | ||
|
|
||
| CLEAN=${CLEAN:-"true"} | ||
|
|
||
| loudecho() { | ||
| echo "###" | ||
| echo "## ${1}" | ||
| echo "#" | ||
| } | ||
|
|
||
| loudecho "Testing in region ${REGION} and zones ${ZONES}" | ||
| mkdir -p "${BIN_DIR}" | ||
| export PATH=${PATH}:${BIN_DIR} | ||
|
|
||
| loudecho "Installing kops ${KOPS_VERSION} to ${BIN_DIR}" | ||
| source "${BASE_DIR}"/utils/kops.sh | ||
| kops::install "${BIN_DIR}" "${KOPS_VERSION}" | ||
| KOPS_BIN=${BIN_DIR}/kops | ||
|
|
||
| loudecho "Installing helm to ${BIN_DIR}" | ||
| source "${BASE_DIR}"/utils/helm.sh | ||
| helm::install "${BIN_DIR}" | ||
| HELM_BIN=${BIN_DIR}/helm | ||
|
|
||
| loudecho "Installing ginkgo to ${BIN_DIR}" | ||
| GINKGO_BIN=${BIN_DIR}/ginkgo | ||
| if [[ ! -e ${GINKGO_BIN} ]]; then | ||
| pushd /tmp | ||
| GOPATH=${TEST_DIR} GOBIN=${BIN_DIR} GO111MODULE=on go get github.com/onsi/ginkgo/[email protected] | ||
| popd | ||
| fi | ||
|
|
||
| AWS_ACCOUNT_ID=$(aws sts get-caller-identity --query Account --output text) | ||
| IMAGE_NAME=${AWS_ACCOUNT_ID}.dkr.ecr.${REGION}.amazonaws.com/aws-ebs-csi-driver | ||
| IMAGE_TAG=${TEST_ID} | ||
| set +e | ||
| if docker images | grep "${IMAGE_NAME}" | grep "${IMAGE_TAG}"; then | ||
| set -e | ||
| loudecho "Assuming ${IMAGE_NAME}:${IMAGE_TAG} has been built and pushed" | ||
| else | ||
| set -e | ||
| loudecho "Building and pushing test driver image to ${IMAGE_NAME}:${IMAGE_TAG}" | ||
| eval "$(aws ecr get-login --region "${REGION}" --no-include-email)" | ||
| docker build -t "${IMAGE_NAME}":"${IMAGE_TAG}" . | ||
| docker push "${IMAGE_NAME}":"${IMAGE_TAG}" | ||
| fi | ||
|
|
||
| loudecho "Generating SSH key $SSH_KEY_PATH" | ||
| if [[ ! -e ${SSH_KEY_PATH} ]]; then | ||
| ssh-keygen -P csi-e2e -f "${SSH_KEY_PATH}" | ||
| fi | ||
|
|
||
| set +e | ||
| if ${KOPS_BIN} get cluster --state "${KOPS_STATE_FILE}" "${CLUSTER_NAME}".k8s.local; then | ||
| set -e | ||
| loudecho "Updating cluster $CLUSTER_NAME" | ||
| else | ||
| set -e | ||
| loudecho "Creating cluster $CLUSTER_NAME" | ||
| ${KOPS_BIN} create cluster --state "${KOPS_STATE_FILE}" \ | ||
| --zones "${ZONES}" \ | ||
| --node-count=3 \ | ||
| --node-size="${INSTANCE_TYPE}" \ | ||
| --kubernetes-version="${K8S_VERSION}" \ | ||
| --ssh-public-key="${SSH_KEY_PATH}".pub \ | ||
| "${CLUSTER_NAME}".k8s.local | ||
| fi | ||
|
|
||
| CLUSTER_YAML_PATH=${TEST_DIR}/${CLUSTER_NAME}.yaml | ||
| ${KOPS_BIN} get cluster --state "${KOPS_STATE_FILE}" "${CLUSTER_NAME}".k8s.local -o yaml > "${CLUSTER_YAML_PATH}" | ||
| cat "${BASE_DIR}"/feature-gates.yaml >> "${CLUSTER_YAML_PATH}" | ||
| cat "${BASE_DIR}"/additional-policies.yaml >> "${CLUSTER_YAML_PATH}" | ||
| ${KOPS_BIN} replace --state "${KOPS_STATE_FILE}" -f "${CLUSTER_YAML_PATH}" | ||
| ${KOPS_BIN} update cluster --state "${KOPS_STATE_FILE}" "${CLUSTER_NAME}".k8s.local --yes | ||
|
|
||
| loudecho "Validating cluster $CLUSTER_NAME" | ||
| ${KOPS_BIN} validate cluster --state "${KOPS_STATE_FILE}" --wait 10m | ||
| VALID=$? | ||
| if [[ $VALID -ne 0 ]]; then | ||
| exit 1 | ||
| fi | ||
|
|
||
| loudecho "Deploying driver" | ||
| ${HELM_BIN} upgrade --install aws-ebs-csi-driver \ | ||
| --namespace kube-system \ | ||
| --set enableVolumeScheduling=true \ | ||
| --set enableVolumeResizing=true \ | ||
| --set enableVolumeSnapshot=true \ | ||
| --set image.repository="${IMAGE_NAME}" \ | ||
| --set image.tag="${IMAGE_TAG}" \ | ||
| ./aws-ebs-csi-driver | ||
|
|
||
| loudecho "Testing focus ${GINKGO_FOCUS}" | ||
| set -x | ||
| ${GINKGO_BIN} -p -nodes="${GINKGO_NODES}" -v --focus="${GINKGO_FOCUS}" --skip="${GINKGO_SKIP}" ./tests/e2e-migration/... -- -kubeconfig="${KUBECONFIG}" -report-dir="${ARTIFACTS}" -gce-zone="${ZONES%,*}" | ||
| TEST_PASSED=$? | ||
| set +x | ||
|
|
||
| if [[ "${CHECK_MIGRATION}" == true ]]; then | ||
| loudecho "Checking migration" | ||
| # There should have been no calls to the in-tree driver kubernetes.io/aws-ebs but many calls to ebs.csi.aws.com | ||
| # Find the controller-manager log and read its metrics to verify | ||
| NODE=$(kubectl get node -l kubernetes.io/role=master -o json | jq -r ".items[].metadata.name") | ||
| kubectl port-forward kube-controller-manager-"${NODE}" 10252:10252 -n kube-system & | ||
|
|
||
| # Ensure port forwarding succeeded | ||
| while true; do | ||
| set +e | ||
| HEALTHZ=$(curl -s 127.0.0.1:10252/healthz) | ||
| set -e | ||
| if [[ ${HEALTHZ} == "ok" ]]; then | ||
| loudecho "Port forwarding succeeded" | ||
| break | ||
| else | ||
| loudecho "Port forwarding is not yet ready" | ||
| fi | ||
| sleep 1 | ||
| done | ||
|
|
||
| set +e | ||
| curl 127.0.0.1:10252/metrics -s | grep -a 'volume_operation_total_seconds_bucket{operation_name="provision",plugin_name="ebs.csi.aws.com"' | ||
| CSI_CALLED=${PIPESTATUS[1]} | ||
| set -e | ||
|
|
||
| set +e | ||
| curl 127.0.0.1:10252/metrics -s | grep -a 'volume_operation_total_seconds_bucket{operation_name="provision",plugin_name="kubernetes.io/aws-ebs"' | ||
| INTREE_CALLED=${PIPESTATUS[1]} | ||
| set -e | ||
|
|
||
| for PROC in $(jobs -p); do | ||
| kill "${PROC}" | ||
| done | ||
|
|
||
| loudecho "CSI_CALLED: ${CSI_CALLED}" | ||
| loudecho "INTREE_CALLED: ${INTREE_CALLED}" | ||
|
|
||
| # TEST_PASSED if tests passed, CSI was called, and In-tree was not called | ||
| if [ "${TEST_PASSED}" == 0 ] && [ "${CSI_CALLED}" == 0 ] && [ "${INTREE_CALLED}" == 1 ]; then | ||
| TEST_PASSED=0 | ||
| else | ||
| TEST_PASSED=1 | ||
| fi | ||
| fi | ||
|
|
||
| if [[ "${CLEAN}" == true ]]; then | ||
| loudecho "Cleaning" | ||
|
|
||
| loudecho "Removing driver" | ||
| ${HELM_BIN} del aws-ebs-csi-driver | ||
|
|
||
| loudecho "Deleting cluster ${CLUSTER_NAME}" | ||
| ${KOPS_BIN} delete cluster --name "${CLUSTER_NAME}".k8s.local --state "${KOPS_STATE_FILE}" --yes | ||
|
|
||
| rm -rf "${TEST_DIR}" | ||
| else | ||
| loudecho "Not cleaning" | ||
| fi | ||
|
|
||
| loudecho "TEST_PASSED: ${TEST_PASSED}" | ||
| if [[ $TEST_PASSED -ne 0 ]]; then | ||
| loudecho "FAIL!" | ||
| exit 1 | ||
| else | ||
| loudecho "SUCCESS!" | ||
| fi | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -uo pipefail | ||
|
|
||
| OS_ARCH=$(go env GOOS)-amd64 | ||
|
|
||
| kops::install() { | ||
| INSTALL_PATH=${1} | ||
| KOPS_VERSION=${2} | ||
| if [[ ! -e ${INSTALL_PATH}/kops ]]; then | ||
| KOPS_DOWNLOAD_URL=https://github.com/kubernetes/kops/releases/download/v${KOPS_VERSION}/kops-${OS_ARCH} | ||
| curl -L -X GET "${KOPS_DOWNLOAD_URL}" -o "${INSTALL_PATH}"/kops | ||
| chmod +x "${INSTALL_PATH}"/kops | ||
| fi | ||
|
There was a problem hiding this comment. Not critical, but it would be helpful to log something in the else such as There was a problem hiding this comment. the curl is not silent, so in a roundabout way it is still possible to tell if the install is being skipped. But yeah, the more logging the better. |
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to verify, we're changing from
ebs-csi-e2etoebs-csi-migration?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, just for the default. The non-migration tests currently go through the tester binary instead of this script anyway. (the theory behind the tester binary is that we can update it once to update all 3 aws csi drivers, so we don't need to maintain 3 almost-identical kops "run-e2e-test" scripts in all 3 repos, but in practice we need to do that anyway since the binary configuratoin yaml is effectively a script: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/tester/single-az-config.yaml)