-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the name of the snapshot controller leader election RoleBinding #601
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
kind: RoleBinding | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
metadata: | ||
name: snapshot-controller-leaderelection | ||
name: ebs-snapshot-controller-leaderelection | ||
namespace: kube-system | ||
labels: | ||
{{- include "aws-ebs-csi-driver.labels" . | nindent 4 }} | ||
|
@@ -13,7 +13,7 @@ subjects: | |
namespace: kube-system | ||
roleRef: | ||
kind: Role | ||
name: snapshot-controller-leaderelection | ||
name: ebs-snapshot-controller-leaderelection | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mentioned this briefly in the commit message / PR description, but I'm unsure how this repository's snapshot controller was working if the snapshot controller from the external-snapshotter repository was installed into a namespace other than kube-system. In that case, the role previously referenced here would not have existed. Are we sure that this role / role binding are needed? |
||
apiGroup: rbac.authorization.k8s.io | ||
|
||
{{- end }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
kind: RoleBinding | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
metadata: | ||
name: snapshot-controller-leaderelection | ||
name: ebs-snapshot-controller-leaderelection | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Running There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let me handle running it again after this meges, this fell off my radar but it's a straightforward fix thank you |
||
namespace: kube-system | ||
labels: | ||
app.kubernetes.io/name: aws-ebs-csi-driver | ||
|
@@ -13,5 +13,5 @@ subjects: | |
namespace: kube-system | ||
roleRef: | ||
kind: Role | ||
name: snapshot-controller-leaderelection | ||
name: ebs-snapshot-controller-leaderelection | ||
apiGroup: rbac.authorization.k8s.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also bump the Helm chart version from 0.6.1 to 0.6.2? Similarly, what's the release process like for the Helm chart? I see it's attached to the GitHub release, but is it released independently as well or do I need to wait for a GitHub release to be cut for this change to be officially available?