Fix default toleration

[krmichel]

Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
This fixes issue #591

[k8s-ci-robot]

Hi @krmichel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krmichel
To complete the pull request process, please assign leakingtapan after the PR has been reviewed.
You can assign the PR to them by writing /assign @leakingtapan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Pull Request Test Coverage Report for Build 1272

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 81.253%

---

Totals
Change from base Build 1269:	0.0%
Covered Lines:	1595
Relevant Lines:	1963

---

💛 - Coveralls

[krmichel]

/assign @leakingtapan
Can I get an ok to test for this?

[leakingtapan]

The taint was CriticalAddonOnly earlier but got removed due to some issue. Let me find it out

[krmichel]

The taint was CriticalAddonOnly earlier but got removed due to some issue. Let me find it out

Okay sounds good. That is kind of what I thought but I looked for a minute and couldn't find the commit where it got removed and thought maybe I just botched a merge. Let me know what you find. I can certainly remove it and make it so tolerations only show up if the user adds their own.

[leakingtapan]

here is the link: #526 (comment)

#526 should be the right change, extra tolerations should be specified through .Values.tolerations. And if you care about turning off tolerating all node, please set .Values.tolerateAllTaints to false

[krmichel]

Closing in favor of #526