-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws-sdk to v1.29.11 to get IMDSv2 support #463
Conversation
Change-Id: I7a05fd6931c4d8596b24cd72c9162af63c5cbcbf
Pull Request Test Coverage Report for Build 1036
💛 - Coveralls |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
|
@leakingtapan my pr did not modify github.com/aws/aws-k8s-tester/e2e/tester/cmd/k8s-e2e-tester dependency. Should we fix it to a specific version instead of picking up master? |
Same error happening in the other driver: kubernetes-sigs/aws-fsx-csi-driver#132 |
Should be fixed by: #468 |
/retest |
Is this a bug fix or adding new feature?
New feature
What is this PR about? / Why do we need it?
Update the SDK to get support for IMDSv2.
There potentially is a latency regression for IMDSv1: aws/aws-sdk-go#2972, but supposedly it has been fixed: aws/aws-sdk-go#3066.
In my testing I have not noticed any regression that would cause driver errors.
What testing is done?
Ran k8s external-storage e2es on a cluster with IMDSv1 (and no v2), and separately on a cluster with IMDSv2 (only) enabled.