-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement topology awareness support for dynamic provisioning #42
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 29
💛 - Coveralls |
Build will be fixed by #43 |
4fe248f
to
04a7c34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor observations, but in general it LGTM. Needs a rebase, though.
We also need an e2e test for this functionality. It can be implemented in another PR, though. Here's an example from GCP: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/test/e2e/tests/multi_zone_e2e_test.go
463336e
to
a20fb44
Compare
Changes includes: 1. return topology in NodeGetInfo response eg. accessible_topology = {"com.amazon.aws.csi.ebs/zone": "us-west-2a"} 2. consumes topology requirement in CreateVolume request and creates volume using the given zone while favoring preferred topologies 3. pick a random zone when topology requirement is not provided (this is the case of dynamic provisioning without delayed binding) 4. Add unit test for pickAvailabilityZone() 5. Add test case for CreateDisk with zone
populate context for `DescribeAvailabilityZonesWithContext`
a20fb44
to
7d48363
Compare
Addressed the comments and also rebased |
/lgtm This is awesome, thank you for implementing this. |
Changes includes:
{"com.amazon.aws.csi.ebs/zone": "us-west-2a"}
volume using the given zone while favoring preferred topologies
(this is the case of dynamic provisioning without delayed binding)
Fixes: #17