-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use kubernetes 1.15 as dependency #345
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add update-gomod.sh for updating go.mod
Nice! TBH I kind of hate that we have to do this, I almost want to stay with dep, but dep is super slow. Anyway it's k/k's fault. Will go mod commands like tidy and vendor still work? |
/lgtm |
go mod vendor still works that's how I get to test this change locally. go mod tidy seems to still works. But I haven't tested it enough |
/retest |
Is this a bug fix or adding new feature?
Since k8s 1.15+ uses go mod for vendering dependencies, it causes problem for dependencies using
replace
directive.Add update-gomod.sh to update go.mod when consuming k/k as go module
Ref: kubernetes/kubernetes#79384