Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use kubernetes 1.15 as dependency #345

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Aug 15, 2019

Is this a bug fix or adding new feature?
Since k8s 1.15+ uses go mod for vendering dependencies, it causes problem for dependencies using replace directive.

Add update-gomod.sh to update go.mod when consuming k/k as go module

Ref: kubernetes/kubernetes#79384

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2019
@coveralls
Copy link

coveralls commented Aug 15, 2019

Pull Request Test Coverage Report for Build 755

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.1%

Totals Coverage Status
Change from base Build 751: 0.0%
Covered Lines: 1176
Relevant Lines: 1654

💛 - Coveralls

Add update-gomod.sh for updating go.mod
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2019
@wongma7
Copy link
Contributor

wongma7 commented Aug 15, 2019

Nice! TBH I kind of hate that we have to do this, I almost want to stay with dep, but dep is super slow. Anyway it's k/k's fault. Will go mod commands like tidy and vendor still work?

@wongma7
Copy link
Contributor

wongma7 commented Aug 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@leakingtapan
Copy link
Contributor Author

Will go mod commands like tidy and vendor still work?

go mod vendor still works that's how I get to test this change locally. go mod tidy seems to still works. But I haven't tested it enough

@wongma7
Copy link
Contributor

wongma7 commented Aug 15, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit debfdb4 into kubernetes-sigs:master Aug 15, 2019
@leakingtapan leakingtapan deleted the k8s branch August 15, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants