Refactor controller unit test with proper mock

[zacharya]

Is this a bug fix or adding new feature?
Refactor Cloud interface unit tests to use GoMock

What is this PR about? / Why do we need it?

• Addresses Refactor controller unit test with proper mock #220 .
• One thing to discuss - moving cloud.FakeCloudProvider to sanity.fakeCloudProvider required exporting cloud.metadata due to the dependency. I don't see any issues with this, but I figured I'd bring it up in case some of the maintainers see problems.

What testing is done?
Both make test and make test-sanity are running fine.

[k8s-ci-robot]

Hi @zacharya. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Pull Request Test Coverage Report for Build 593

• 22 of 26 (84.62%) changed or added relevant lines in 3 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+5.3%) to 70.394%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/driver/fakes.go	0	1	0.0%
pkg/driver/controller.go	12	15	80.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/driver/controller.go	1	68.37%

Totals
Change from base Build 575:	5.3%
Covered Lines:	1001
Relevant Lines:	1422

---

💛 - Coveralls

[leakingtapan]

/ok-to-test

[zacharya]

/retest

[zacharya]

/retest

[zacharya]

/retest

[leakingtapan]

Im okay with making metadata struct public.

[leakingtapan]

Thx for send the PR. The testing code looks much cleaner and we have a higher coverage! I just finished half of the PR. will finish the rest.

[zacharya]

Thanks for the review. I'll knock these out first thing tomorrow.

[zacharya]

@leakingtapan I think I've touched on all of your suggestions. I went through each test case with the goal of making each more readable (rather than bring the dynamic error handling logic over from the previous state). Let me know if you see anything that still needs fixing.

[leakingtapan]

/retest

[zacharya]

/retest

[leakingtapan]

The code a lot readable and more test covered now Thank @zacharya

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, zacharya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [leakingtapan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bertinatto]

Just a heads up about this PR: we should always squash commits as much as possible.

[leakingtapan]

+1 Forgot to remind @zacharya of doing this.

[zacharya]

@bertinatto @leakingtapan Will do next time