Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image for runtime deployment #236

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Update image for runtime deployment #236

merged 1 commit into from
Mar 7, 2019

Conversation

leakingtapan
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from d-nishi and ddebroy March 7, 2019 01:00
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2019
@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 511

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.689%
Totals Coverage Status
Change from base Build 507: 0.0%
Covered Lines: 997
Relevant Lines: 1495
💛 - Coveralls

@leakingtapan
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-integration

@dkoshkin
Copy link
Contributor

dkoshkin commented Mar 7, 2019 •
edited
Loading

We should also include the liveness-probe in the diagram right?

Also I am not seeing how this file is being used.

@leakingtapan
Copy link
Contributor Author

It will be used here: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/wiki/Architecture-Diagrams

@leakingtapan
Copy link
Contributor Author

We should also include the liveness-probe in the diagram right?

Updated

@leakingtapan
Copy link
Contributor Author

/retest

1 similar comment
@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan leakingtapan merged commit 70852ac into kubernetes-sigs:master Mar 7, 2019
@leakingtapan leakingtapan deleted the img branch March 7, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leakingtapan @k8s-ci-robot @coveralls @dkoshkin