Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in e2e test #224

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Feb 24, 2019

Is this a bug fix or adding new feature?
Fix bug in e2e test where cleanup is missing for dynamic created pvs and pre created pvs.

Testing
Saw pvc deleting log for each pvc instead of only one:

�[1mSTEP�[0m: Deleting pod ebs-volume-tester-nrc2f in namespace e2e-tests-ebs-ccr6c
Feb 24 17:39:20.779: INFO: deleting PVC "e2e-tests-ebs-ccr6c"/"pvc-r6l9h"
Feb 24 17:39:20.779: INFO: Deleting PersistentVolumeClaim "pvc-r6l9h"
�[1mSTEP�[0m: waiting for claim's PV "pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534" to be deleted
Feb 24 17:39:20.845: INFO: Waiting up to 10m0s for PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 to get deleted
Feb 24 17:39:20.914: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 found and phase=Released (69.126832ms)
Feb 24 17:39:25.979: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 found and phase=Released (5.134088766s)
Feb 24 17:39:31.063: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 found and phase=Released (10.217669843s)
Feb 24 17:39:36.128: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 found and phase=Released (15.283071825s)
Feb 24 17:39:41.193: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 found and phase=Released (20.347712215s)
Feb 24 17:39:46.258: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 found and phase=Released (25.413006618s)
Feb 24 17:39:51.326: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 found and phase=Released (30.480756698s)
Feb 24 17:39:56.393: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 found and phase=Released (35.547826331s)
Feb 24 17:40:01.460: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 found and phase=Released (40.614691837s)
Feb 24 17:40:06.525: INFO: PersistentVolume pvc-f5047e9e-385a-11e9-abc0-025ab9cfe534 was removed
Feb 24 17:40:06.525: INFO: Waiting up to 5m0s for PersistentVolumeClaim e2e-tests-ebs-ccr6c to be removed
Feb 24 17:40:06.589: INFO: Claim "e2e-tests-ebs-ccr6c" in namespace "pvc-r6l9h" doesn't exist in the system
Feb 24 17:40:06.589: INFO: deleting StorageClass e2e-tests-ebs-ccr6c-ebs.csi.aws.com-dynamic-sc-2xs5b
Feb 24 17:40:06.661: INFO: deleting PVC "e2e-tests-ebs-ccr6c"/"pvc-d985d"
Feb 24 17:40:06.661: INFO: Deleting PersistentVolumeClaim "pvc-d985d"
�[1mSTEP�[0m: waiting for claim's PV "pvc-e87ddcb4-385a-11e9-abc0-025ab9cfe534" to be deleted
Feb 24 17:40:06.728: INFO: Waiting up to 10m0s for PersistentVolume pvc-e87ddcb4-385a-11e9-abc0-025ab9cfe534 to get deleted
Feb 24 17:40:06.792: INFO: PersistentVolume pvc-e87ddcb4-385a-11e9-abc0-025ab9cfe534 found and phase=Released (64.409588ms)
Feb 24 17:40:11.857: INFO: PersistentVolume pvc-e87ddcb4-385a-11e9-abc0-025ab9cfe534 was removed
Feb 24 17:40:11.857: INFO: Waiting up to 5m0s for PersistentVolumeClaim e2e-tests-ebs-ccr6c to be removed
Feb 24 17:40:11.922: INFO: Claim "e2e-tests-ebs-ccr6c" in namespace "pvc-d985d" doesn't exist in the system
Feb 24 17:40:11.922: INFO: deleting StorageClass e2e-tests-ebs-ccr6c-ebs.csi.aws.com-dynamic-sc-jzfbb

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2019
@coveralls
Copy link

coveralls commented Feb 24, 2019

Pull Request Test Coverage Report for Build 472

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.773%

Totals Coverage Status
Change from base Build 468: 0.0%
Covered Lines: 980
Relevant Lines: 1446

💛 - Coveralls

@dkoshkin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5b3ddbe into kubernetes-sigs:master Feb 26, 2019
@leakingtapan leakingtapan deleted the e2e branch February 26, 2019 19:33
jsafrane pushed a commit to jsafrane/aws-ebs-csi-driver that referenced this pull request Aug 9, 2023
OCPBUGS-10816: Volume unmount repeats after successful unmount, preventing pod delete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants