Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/structured-merge-diff/v4 from 4.4.1 to 4.4.2 in the k8s-dependencies group #2209

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 6, 2024

Bumps the k8s-dependencies group with 1 update: sigs.k8s.io/structured-merge-diff/v4.

Updates sigs.k8s.io/structured-merge-diff/v4 from 4.4.1 to 4.4.2

Commits
  • ccf7a06 Merge pull request #265 from jpbetz/reset-filter
  • b499124 Merge pull request #266 from jpbetz/add-owners
  • 39c90b6 Add volunteer reviewers
  • bda634e Apply feedback
  • a8ac1f5 Optimize merge, make wildcards always take precedence
  • f395ded Apply feedback
  • 1311e4d Add support for more field path pattern types, clarify comments
  • 1206de6 Clean up comments
  • 083ce27 Add field path pattern matching
  • c68c9ee Accept filter instead of exclude mask for ignored fields
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andrewsirenko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2024
@AndrewSirenko
Copy link
Contributor

@dependabot rebase

Bumps the k8s-dependencies group with 1 update: [sigs.k8s.io/structured-merge-diff/v4](https://github.com/kubernetes-sigs/structured-merge-diff).


Updates `sigs.k8s.io/structured-merge-diff/v4` from 4.4.1 to 4.4.2
- [Release notes](https://github.com/kubernetes-sigs/structured-merge-diff/releases)
- [Changelog](https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/structured-merge-diff@v4.4.1...v4.4.2)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/structured-merge-diff/v4
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s-dependencies-057a5e3597 branch from 754a913 to af8131c Compare November 7, 2024 21:38
@AndrewSirenko
Copy link
Contributor

Looks like this indirect dependency upgrade doesn't play nice with api-machinery util:

> make
...
# k8s.io/apimachinery/pkg/util/managedfields/internal
../../go/pkg/mod/k8s.io/[email protected]/pkg/util/managedfields/internal/structuredmerge.go:56:4: unknown field IgnoredFields in struct literal of type merge.Updater
../../go/pkg/mod/k8s.io/[email protected]/pkg/util/managedfields/internal/structuredmerge.go:73:4: unknown field IgnoredFields in struct literal of type merge.Updater
make: *** [bin/aws-ebs-csi-driver] Error 1

Let's skip this bump until apimachinery gets bumped?

@k8s-ci-robot
Copy link
Contributor

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-unit af8131c link true /test pull-aws-ebs-csi-driver-unit
pull-aws-ebs-csi-driver-verify af8131c link true /test pull-aws-ebs-csi-driver-verify
pull-aws-ebs-csi-driver-e2e-single-az af8131c link true /test pull-aws-ebs-csi-driver-e2e-single-az
pull-aws-ebs-csi-driver-e2e-multi-az af8131c link true /test pull-aws-ebs-csi-driver-e2e-multi-az
pull-aws-ebs-csi-driver-external-test af8131c link true /test pull-aws-ebs-csi-driver-external-test
pull-aws-ebs-csi-driver-external-test-arm64 af8131c link false /test pull-aws-ebs-csi-driver-external-test-arm64
pull-aws-ebs-csi-driver-test-helm-chart af8131c link true /test pull-aws-ebs-csi-driver-test-helm-chart
pull-aws-ebs-csi-driver-external-test-eks af8131c link true /test pull-aws-ebs-csi-driver-external-test-eks
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows af8131c link true /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AndrewSirenko
Copy link
Contributor

@dependabot ignore sigs.k8s.io/structured-merge-diff/v4 patch version

@dependabot dependabot bot closed this Nov 8, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 8, 2024

OK, I won't notify you about version 4.4.2 of sigs.k8s.io/structured-merge-diff/v4 again, unless you unignore it.

@dependabot dependabot bot deleted the dependabot/go_modules/k8s-dependencies-057a5e3597 branch November 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants