Add v1 Karpenter disrupted taint to pre-stop hook #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Code Coverage Diff
|
|
/retest windows flake for volume expansion |
torredil
approved these changes
Oct 4, 2024
k8s-ci-robot
added
the
lgtm
ElijahQuinones
approved these changes
Oct 4, 2024
ConnorJC3
requested changes
Oct 7, 2024
k8s-ci-robot
removed
the
lgtm
AndrewSirenko
force-pushed
the
update-pre-stop
branch
2 times, most recently
from
b420df6 to
74319cd
Compare
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
@ElijahQuinones Not a flake, need to reformat the module import |
AndrewSirenko
force-pushed
the
update-pre-stop
branch
from
74319cd to
361df2c
Compare
k8s-ci-robot
removed
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
Fixes #2158
Our pre-stop hook attempts to keep the EBS CSI Driver node plugin alive while node is being drained so that it can Unstage/Unpublish all volumes and report that to Kubelet before node termination. Karpenter v1 changed their disruption taint, so we need to update our pre-stop hook to check for it.
We also remove the dependency on Karpenter because we are compatible with multiple versions of it, and switch to just checking taint key instead of taint key and effect in case these auto-scalars switch to a
NoExecuteeffect.What testing is done?
New unit tests.
TODO test with karpenter v1.