-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for outpost nodegroups to make cluster/create
#2135
Add support for outpost nodegroups to make cluster/create
#2135
Conversation
7b0f41b
to
12e4797
Compare
Signed-off-by: Connor Catlett <[email protected]>
12e4797
to
189a228
Compare
Looks good to me tested these changes to the make file on teams outpost account and they worked for me as well. /lgtm |
@ElijahQuinones: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One recommendation, otherwise looks great! Thanks for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
New feature for
Maklefile
What is this PR about? / Why do we need it?
Adds the ability to create an outposts nodegroup when creating an
eksctl
cluster throughmake cluster/create
, which greatly simplifies debugging outpost-only features of the driver.What testing is done?
Manually tested with: