Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for outpost nodegroups to make cluster/create #2135

Merged

Conversation

ConnorJC3
Copy link
Contributor

Is this a bug fix or adding new feature?

New feature for Maklefile

What is this PR about? / Why do we need it?

Adds the ability to create an outposts nodegroup when creating an eksctl cluster through make cluster/create, which greatly simplifies debugging outpost-only features of the driver.

What testing is done?

Manually tested with:

export CLUSTER_TYPE=eksctl
export AWS_REGION=us-east-1
export AWS_AVAILABILITY_ZONES=us-east-1a,us-east-1b
export OUTPOST_ARN="arn:aws:outposts:us-east-1:REDACTED:outpost/op-REDACTED"
export OUTPOST_INSTANCE_TYPE=c5.xlarge

make cluster/create

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2024
@ConnorJC3 ConnorJC3 force-pushed the outpost-makefile-support branch from 7b0f41b to 12e4797 Compare September 6, 2024 19:14
@ConnorJC3 ConnorJC3 force-pushed the outpost-makefile-support branch from 12e4797 to 189a228 Compare September 6, 2024 19:34
@ElijahQuinones
Copy link
Member

Looks good to me tested these changes to the make file on teams outpost account and they worked for me as well.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@ElijahQuinones: changing LGTM is restricted to collaborators

In response to this:

Looks good to me tested these changes to the make file on teams outpost account and they worked for me as well.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One recommendation, otherwise looks great! Thanks for this.

docs/makefile.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2024
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@AndrewSirenko
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit c365bf6 into kubernetes-sigs:master Sep 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants