Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create constants for keys used in map lookup #211

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Create constants for keys used in map lookup #211

merged 1 commit into from
Feb 14, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
/maintenance

What is this PR about? / Why do we need it?
Create constants for keys used in map lookup

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 13, 2019
@coveralls
Copy link

coveralls commented Feb 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 443

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.433%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/controller.go 6 7 85.71%
Totals Coverage Status
Change from base Build 439: 0.0%
Covered Lines: 779
Relevant Lines: 1209
💛 - Coveralls

@leakingtapan leakingtapan merged commit 8bb2cd2 into kubernetes-sigs:master Feb 14, 2019
@leakingtapan leakingtapan deleted the constant branch February 14, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leakingtapan @k8s-ci-robot @coveralls