-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace coalescer implementation with new coalescer package #2025
Conversation
Code Coverage Diff
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
−316
Thank you for this. This change significantly improves the modify volume implementation.
/lgtm
Signed-off-by: Connor Catlett <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Is this a bug fix or adding new feature?
New feature
What is this PR about? / Why do we need it?
Replaces the previous mixed-in coalescer implementation with the new package from #2024
What this PR does NOT do, on purpose:
cloud.ModifyDiskOptions
andcloud.ModifyOrResizeDisk
: I think the remainingModifyVolume
code could be greatly simplified by moving the size intoModifyDiskOptions
(rather than having it as a separate parameter), but this PR is not the place to do soWhat testing is done?
CI/Unit Tests