-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI options to run metrics endpoint over HTTPS #2014
Conversation
Signed-off-by: Connor Catlett <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
1ba86c8
to
0c38366
Compare
Code Coverage Diff
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code itself lgtm other than missing options documentation page updates
Thank you for removing the 2 panics.
Signed-off-by: Connor Catlett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Is this a bug fix or adding new feature?
New feature (and related bugfix)
What is this PR about? / Why do we need it?
Add options to run metrics endpoint over HTTPS
Adds the ability to run the metrics server via HTTPS by supplying a certificate and key.
Validate options in main.go
Adds missing
Validate()
call tomain.go
What testing is done?
CI/manual/Added unit tests