-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Hardcode buildkit verison to 0.12.5 #1985
Conversation
Signed-off-by: Connor Catlett <[email protected]>
Code Coverage DiffThis PR does not change the code coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Raising the priority of our 'audit unpinned dependencies' task
Nit: Can we cherrypick instead of opening 3 PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
Buildkit 0.13.0 and above don't correctly forward
os.version
for Windows images in multi-arch manifests. Hardcode buildkit to 0.12.5What testing is done?
Manually tested locally via
./hack/prow.sh
(need to modify registry inside)