Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor util package and add unit tests #197

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Refactor util package and add unit tests #197

merged 1 commit into from
Feb 3, 2019
+54 −12

Conversation

leakingtapan
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 405

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 64.433%
Totals Coverage Status
Change from base Build 404: 1.3%
Covered Lines: 779
Relevant Lines: 1209
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 405

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 64.433%
Totals Coverage Status
Change from base Build 404: 1.3%
Covered Lines: 779
Relevant Lines: 1209
💛 - Coveralls

@leakingtapan
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-e2e-single-az

@leakingtapan leakingtapan merged commit f5e9cbb into kubernetes-sigs:master Feb 3, 2019
@leakingtapan leakingtapan deleted the util branch February 3, 2019 00:35
jsafrane pushed a commit to jsafrane/aws-ebs-csi-driver that referenced this pull request May 4, 2022
@openshift-merge-robot
Merge pull request kubernetes-sigs#197 from dobsonj/art-ocp4.11-update
6c784e4 
Updating ose-aws-ebs-csi-driver images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leakingtapan @k8s-ci-robot @coveralls