Fix Small Papercuts 2.0 #1953
Merged
Fix Small Papercuts 2.0 #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Catlett <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
Code Coverage Diff
|
|
/retest Looks like AWS-side flake |
AndrewSirenko
requested changes
Mar 1, 2024
Signed-off-by: Connor Catlett <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
AndrewSirenko
approved these changes
Mar 1, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Largely bug fix
What is this PR about? / Why do we need it?
Fixes three small issues:
Add missing kubeconfig in kops.sh
Adds a
--kubeconfig dev/nullmissed in #1933Cleanup README images and compatibility
Change README section to only supported images, update release PRs script to account for this change.
Refactor options.go so that flags are always loaded
Fixes #1952 by refactoring the logic to greatly simplify the control flow, also adds a unit test for an entirely blank arguments set.
What testing is done?
Manual/Added unit test/CI