Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest to use 0.2.0 driver #193

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Update manifest to use 0.2.0 driver #193

merged 2 commits into from
Jan 30, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
/release

What is this PR about? / Why do we need it?
Update manifest to use 0.2.0 driver

@leakingtapan leakingtapan requested a review from dkoshkin January 28, 2019 18:21
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 393

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.14%
Totals Coverage Status
Change from base Build 390: 0.0%
Covered Lines: 764
Relevant Lines: 1210
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 28, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 394

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.14%
Totals Coverage Status
Change from base Build 390: 0.0%
Covered Lines: 764
Relevant Lines: 1210
💛 - Coveralls

@leakingtapan
Copy link
Contributor Author

/hold
until the image is pushed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2019
dkoshkin
dkoshkin reviewed Jan 28, 2019
View reviewed changes
deploy/kubernetes/controller.yaml
@@ -125,7 +125,7 @@ spec:
operator: Exists
containers:
- name: ebs-plugin
image: amazon/aws-ebs-csi-driver:latest
image: amazon/aws-ebs-csi-driver:0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Docker tag is 0.2.0 but the Github tag is v0.2.0-alpha.0. Is the expectation is that git will be retagged to 0.2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. 0.2.0 will be the final release tag

dkoshkin
dkoshkin approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, the dockerhub tag is not up yet so could not test with 0.2.0 but I did test latest tag (what will become 0.2.0) and it all looks good.

@leakingtapan
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2019
@leakingtapan leakingtapan merged commit 6448a8b into kubernetes-sigs:master Jan 30, 2019
@leakingtapan leakingtapan deleted the manifest branch January 30, 2019 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoshkin dkoshkin dkoshkin approved these changes

@bertinatto bertinatto Awaiting requested review from bertinatto

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leakingtapan @k8s-ci-robot @coveralls @dkoshkin