Remove premature CreateVolume error if requested IOPS is below minimum #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
Code Coverage DiffThis PR does not change the code coverage |
AndrewSirenko
force-pushed
the
remove-minimum-iops-validation
branch
from
f57bf3d to
190f526
Compare
|
/retest |
torredil
reviewed
Jan 3, 2024
k8s-ci-robot
added
lgtm
AndrewSirenko
force-pushed
the
remove-minimum-iops-validation
branch
from
190f526 to
7e8ec74
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
EBS CSI Driver will let EC2 CreateVolume enforce minimum IOPS values instead of enforcing the hardcoded minimum limits in cloud.go (Unless
allowAutoIOPSPerGBIncreaseis set).Note: This is a volume-type agnostic version of PR #1879, as requested by EBS CSI Driver team.
Pro:
Con:
infeasablePVC status is added to CreateVolume similar to how it was added for Update ControllerModifyVolume Status API #4298). This could increase chance of EC2 throttling, but can be solved at the Kubernetes + CSI level viainfeasablePVC parameter.See #1879
What testing is done?
make test, Manual testing