Bugfix: Instances listed under maxVolumeLimits not taking into account ENIs/Instance storage
#1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Code Coverage DiffThis PR does not change the code coverage |
…t ENIs/Instance storage Signed-off-by: Eddie Torres <[email protected]>
Signed-off-by: Eddie Torres <[email protected]>
torredil
force-pushed
the
bugfix-volume_limits
branch
from
61905a1 to
0862ff1
Compare
k8s-ci-robot
added
size/M
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
AndrewSirenko
approved these changes
Dec 12, 2023
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Bugfix
closes #1688
What is this PR about? / Why do we need it?
This PR addresses a bug in the driver where the calculation that subtracts ENIs and Instance store values is bypassed for certain instance types. More specifically, instance types included in
maxVolumeLimits: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/v1.21.0/pkg/cloud/volume_limits.go#L56-66.As an example,
d3.8xlarge(nitro instance) reports a value of3: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/6f2db761cfa352e05483b7f360b4ed9053b382d6/pkg/cloud/volume_limits.go#L57C3-L57C13 even when several ENIs are attached.Following the current logic,
availableAttachmentsis equal to the default value ofnitroMaxAttachments=28when enis and instance store volumes are taken into account. Finally, taking the min ofmaxVolumeLimitsandavailableAttachments, the value is incorrectly set to 3.With this change,
availableAttachmentsis set tomaxVolumeLimitsif necessary before the calculation is performed so that enis and instance store volumes can be correctly taken into account.What testing is done?
make test