-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump otelhttp to fix CVE-2023-45142 #1858
Conversation
Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to fix CVE-2023-47108. See GHSA-8pgv-569h-w5rw for details.
Code Coverage Diff
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsafrane thank you for this
make verify
needs fixing, otherwise lgtm:
pkg/driver/driver.go:158:56: SA1019: otelgrpc.UnaryServerInterceptor is deprecated: Use [NewServerHandler] instead. (staticcheck)
grpcInterceptor = grpc.ChainUnaryInterceptor(logErr, otelgrpc.UnaryServerInterceptor())
Replace it with otelgrpc.NewServerHandler.
@torredil I just pushed a second commit reworking how OpenTelemetry is injected into gRPC, however, I have no means to test it. |
/test pull-aws-ebs-csi-driver-test-helm-chart |
/retest Did I break anything?
|
@jsafrane This is related to #1856 (comment) |
@dims The failure here is coming from IRSA on the CI cluster failing to get the role for the CI job. All jobs referencing Same issue observed for the cloud-provider-aws-e2e periodic: https://testgrid.k8s.io/provider-aws-periodics#ci-cloud-provider-aws-e2e:
|
/retest |
1 similar comment
/retest |
/lgtm approving so this merges as soon as CI fixes |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to fix CVE-2023-47108.
See GHSA-8pgv-569h-w5rw for details.
I had to rework how OpenTelemetry is used by the CSI driver gRPC connection. I was not able to test it though.