Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Superseeded PR #1854

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Superseeded PR #1854

wants to merge 1 commit into from

Conversation

ConnorJC3
Copy link
Contributor

@ConnorJC3 ConnorJC3 commented Dec 7, 2023 •
edited
Loading

This PR was used for testing CI and was superseded by #1856

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from connorjc3. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 7, 2023
@ConnorJC3 ConnorJC3 force-pushed the optimize-runsh-makefile branch from 5230b38 to ea0e30b Compare December 7, 2023 00:36
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2023
@ConnorJC3 ConnorJC3 force-pushed the optimize-runsh-makefile branch 2 times, most recently from fa42efb to ebc084f Compare December 7, 2023 00:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Code Coverage Diff

This PR does not change the code coverage

@ConnorJC3 ConnorJC3 force-pushed the optimize-runsh-makefile branch 6 times, most recently from abc7e17 to 2c46827 Compare December 7, 2023 02:11
@ConnorJC3
Copy link
Contributor Author

/retest

@ConnorJC3 ConnorJC3 force-pushed the optimize-runsh-makefile branch 6 times, most recently from 9da0e5c to d12f685 Compare December 7, 2023 18:15
@ConnorJC3 ConnorJC3 mentioned this pull request Dec 7, 2023
Merged
@ConnorJC3
Copy link
Contributor Author

/retest

1 similar comment
@ConnorJC3
Copy link
Contributor Author

/retest

@ConnorJC3
Refactor the Makefile and hack scripts
99add14 
See the PR description for more information about this change

Signed-off-by: Connor Catlett <[email protected]>
@ConnorJC3 ConnorJC3 force-pushed the optimize-runsh-makefile branch from d12f685 to 99add14 Compare December 7, 2023 19:27
@ConnorJC3
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@ConnorJC3: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@ConnorJC3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-external-test-eks 99add14 link true /test pull-aws-ebs-csi-driver-external-test-eks
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows 99add14 link true /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows
pull-aws-ebs-csi-driver-external-test 99add14 link true /test pull-aws-ebs-csi-driver-external-test
pull-aws-ebs-csi-driver-e2e-single-az 99add14 link true /test pull-aws-ebs-csi-driver-e2e-single-az
pull-aws-ebs-csi-driver-test-helm-chart 99add14 link true /test pull-aws-ebs-csi-driver-test-helm-chart
pull-aws-ebs-csi-driver-external-test-arm64 99add14 link false /test pull-aws-ebs-csi-driver-external-test-arm64
pull-aws-ebs-csi-driver-verify 99add14 link true /test pull-aws-ebs-csi-driver-verify
pull-aws-ebs-csi-driver-e2e-multi-az 99add14 link true /test pull-aws-ebs-csi-driver-e2e-multi-az
pull-aws-ebs-csi-driver-unit 99add14 link true /test pull-aws-ebs-csi-driver-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ConnorJC3 ConnorJC3 changed the title [DO NOT MERGE] test PR [DO NOT MERGE] Superceded PR Dec 7, 2023
@ConnorJC3 ConnorJC3 changed the title [DO NOT MERGE] Superceded PR [DO NOT MERGE] Superseeded PR Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSirenko AndrewSirenko Awaiting requested review from AndrewSirenko

@torredil torredil Awaiting requested review from torredil

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConnorJC3 @k8s-ci-robot