Enable CSI sanity/conformance tests

[torredil]

What is this PR about? / Why do we need it?

This PR enables csi-sanity / conformance tests, which are meant to test the CSI API capability of a driver. They are meant to be an additional test to the unit, functional, and e2e tests of a CSI driver.

The following 3 tests fail:

• [Fail] Node Service NodeExpandVolume [It] should fail when volume is not found /home/go/pkg/mod/github.com/kubernetes-csi/csi-test/[email protected]/pkg/sanity/node.go:786

• [Fail] Node Service NodeExpandVolume [It] should work if node-expand is called after node-publish /home/go/pkg/mod/github.com/kubernetes-csi/csi-test/[email protected]/pkg/sanity/node.go:837

• [Fail] Node Service [It] should work /home/go/pkg/mod/github.com/kubernetes-csi/csi-test/[email protected]/pkg/sanity/node.go:177

Due to

aws-ebs-csi-driver/pkg/driver/node_linux.go

Line 163 in 551b59a

func (d *nodeService) IsBlockDevice(fullPath string) (bool, error) {

incorrectly being part of the node service. In doing this work, I realized that our node service needs to be revisited as there is logic specific to the mounter interface that has made its way into the node service which really needs decoupling.

Ideally, we should be able to make use of NewFakeMounter from mount-utils. However, this is currently not possible as we implement a custom Mounter interface that is a mix & match of functions defined in the upstream library.

What testing is done?

$ make test-sanity

Ran 67 of 78 Specs in 4.073 seconds
FAIL! -- 64 Passed | 3 Failed | 1 Pending | 10 Skipped

[github-actions]

Code Coverage Diff

File	Old Coverage	New Coverage	Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller.go	86.0%	83.8%	-2.1
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/driver.go	63.6%	31.9%	-31.8
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/identity.go	37.5%	0.0%	-37.5
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/mount.go	71.4%	42.9%	-28.6
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/node.go	80.0%	79.5%	-0.5

[AndrewSirenko]

Left a mix of nits, requests, and out-of-scope comments. LGTMing because this PR is a two-way-door and requested changes are not blocking.

[AndrewSirenko]

Consider adding test-sanity as dependency for make test once we fix these 3 broken tests. These sanity tests are unit-tests (no external dependencies), therefore they finish (almost) instantly. Contributors would also self-service csi-spec gotchas more easily. (Not sure a contributor would remember to run make test-sanity but they would hopefully be running make test)

[ConnorJC3]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ConnorJC3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[torredil]

/test pull-aws-ebs-csi-driver-verify