Refactor E2E: Streamline setting of CreateVolume Parameters in test-cases.

[AndrewSirenko]

Is this a bug fix or adding new feature?
Refactor

What is this PR about? / Why do we need it?
The aws-ebs-csi-driver's E2E tests currently rely on test-specific helper-function behavior and kitchen-sink wrapper-structs (See the git-blame for the VolumeDetails). While test-specific extra helper-function-logic and wrapper-struct-fields helped increase the driver's test-coverage sooner, they negatively impact the discoverability and readability of these utility functions when writing more e2e tests.

This PR begins to standardize these disparate ways of writing e2e tests by having any test that dynamically provisions volumes rely on explicitly setting CreateVolume (StorageClass) Parameters within the test-cases.

These commits are bundled into one PR to simplify code review + CI (Prow tests + Merging).

The purposes of each commit are:

• Refactor E2E: Remove hidden volume performance parameter setting
  • Currently, dynamically provisioning volumes via E2E helper functions secretly sets iops, iopsPerGb, or throughput based on the volumeType passed into a VolumeDetails struct. Worse, E2E packages should not be responsible for maintaining a source of truth for EBS limits like maximum throughput for each volume type. Instead, unless E2E tests are explicitly testing these performance parameters, their default should be left to the EC2 API (via the driver) or be explicitly set in test-case parameters via constants like DefaultE2EIopsIoVolumes.
• Fixup E2E: Pre-Provisioned volumes don't use VolumeType and Fixup E2E: Pre-Provisioned defaultVolumeType typo
  • Small clean-ups of existing code.
• Refactor E2E: Standardize adding CreateVolume parameters to testcases
  • When dynamically provisioning volumes, test-case fields like VolumeType, FSType, and Encrypted are CreateVolume parameters and should not be treated differently from parameters like iops and blockSize when creating tests.
• Refactor E2E: Generalize format_options CreateVolumeDetails helper fcn.
  • Cleans up format_options E2E tests based on previous refactors, as well as generalizes createFormatOptionVolumeDetails so that future E2E tests like those for the ModifyVolume feature can use it.

What testing is done?
All E2E tests passed locally after each commit.

[github-actions]

Code Coverage Diff

This PR does not change the code coverage

[ConnorJC3]

If this isn't used in the driver itself, it should be in the e2e package.

[AndrewSirenko]

We should use it in the driver here:

aws-ebs-csi-driver/pkg/driver/controller.go

Line 160 in 61c721b

klog.InfoS("\"fstype\" is deprecated, please use \"csi.storage.k8s.io/fstype\" instead")

If all other parameter keys mentioned in our docs are in constants.go I think that FSTypeKey belongs there as well. Especially because if one day we do use this key in the driver for something more substantial, we would have a duplicated constant.

[torredil]

/lgtm

[ConnorJC3]

/lgtm

[torredil]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment