Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor example file structure #184

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
/maintenance

What is this PR about? / Why do we need it?
Move example into its own folder under examples/kubernetes. We could add more examples there in the future

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2019
@coveralls
Copy link

coveralls commented Jan 21, 2019

Pull Request Test Coverage Report for Build 344

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.931%

Totals Coverage Status
Change from base Build 343: 0.0%
Covered Lines: 602
Relevant Lines: 1182

💛 - Coveralls

@leakingtapan leakingtapan changed the title Refactor file structure Refactor example file structure Jan 22, 2019
@bertinatto
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2a5d5ff into kubernetes-sigs:master Jan 22, 2019
@leakingtapan leakingtapan deleted the example branch January 23, 2019 04:02
bertinatto pushed a commit to bertinatto/aws-ebs-csi-driver that referenced this pull request Apr 30, 2021
Bug 1932152: UPSTREAM: 809: Cap IOPS when calculating from iopsPerGB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants