Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VolumeNameTagKey #174

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
Fixes: #161

What is this PR about? / Why do we need it?
The key name doesn't need to be the same as previous driver name

What testing is done?
unit test

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2019
@coveralls
Copy link

coveralls commented Jan 8, 2019

Pull Request Test Coverage Report for Build 321

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.525%

Totals Coverage Status
Change from base Build 317: 0.0%
Covered Lines: 577
Relevant Lines: 1142

💛 - Coveralls

@leakingtapan leakingtapan merged commit a282418 into kubernetes-sigs:master Jan 9, 2019
@leakingtapan leakingtapan deleted the rename-key branch January 9, 2019 03:49
huffmanca pushed a commit to huffmanca/aws-ebs-csi-driver that referenced this pull request Nov 23, 2020
Bug 1876935: UPSTREAM: 568: Apply extra volume tags to EBS snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename VolumeNameTagKey
3 participants