Additional DaemonSets feature #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
ConnorJC3
force-pushed
the
additional-nodegroups
branch
from
313dff4 to
86e0b2e
Compare
k8s-ci-robot
added
size/XXL
ConnorJC3
force-pushed
the
additional-nodegroups
branch
from
86e0b2e to
6331276
Compare
k8s-ci-robot
added
size/XL
ConnorJC3
force-pushed
the
additional-nodegroups
branch
from
6331276 to
39b857b
Compare
|
/retest |
ConnorJC3
changed the title
k8s-ci-robot
added
needs-rebase
ConnorJC3
force-pushed
the
additional-nodegroups
branch
from
39b857b to
0b1e10e
Compare
k8s-ci-robot
removed
the
needs-rebase
ConnorJC3
force-pushed
the
additional-nodegroups
branch
from
0b1e10e to
8357877
Compare
|
/retest |
1 similar comment
|
/retest |
ConnorJC3
force-pushed
the
additional-nodegroups
branch
from
8357877 to
f8e0001
Compare
Signed-off-by: Connor Catlett <[email protected]>
ConnorJC3
force-pushed
the
additional-nodegroups
branch
from
f8e0001 to
6cfba34
Compare
torredil
approved these changes
Sep 11, 2023
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
New feature
What is this PR about? / Why do we need it?
Adds ability to create additional
DaemonSets for nodes with different configurations (also see added filedocs/additional-daemonsets.md)What testing is done?
Manual/CI