Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI image version and deployment manifests updates #171

Merged
merged 2 commits into from
Jan 17, 2019
Merged

CSI image version and deployment manifests updates #171

merged 2 commits into from
Jan 17, 2019

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Jan 7, 2019 •
edited
Loading

Is this a bug fix or adding new feature?
Fixes #158

What is this PR about? / Why do we need it?
This PR replaces the deprecated https://github.com/kubernetes-csi/driver-registrar with:

  • Because the driver-registrar is now replaced with 2 different images one cluster-driver-registrar and one node-driver-registrar it no longer makes sense to have both of those pods in the csi-node DS as node-driver-registrar is a cluster level component and should register the driver once, ie in a single pod.
    To support this, this PR also merged the attacher.yaml and provisioner.yaml into a single controller.yaml StatefulSet (this is also consistent how other CSI drivers including DOs and GCPs does it)
    I also went through all the RBAC policies and tested them to confirm there aren't any extra/missing ones.
  • Replaced quay.io/k8scsi/csi-attacher:v1.0-canary and external-provisioner images with a stable latest release v1.0.1 - having version predictability is always good - Interested on everyone else's thoughts on this.
  • Set priorityClassName which requires the pods to run in kube-system namespace.
  • I also removed directories for versions pre v1.13, Kubernetes v1.13 uses CSI 1.0 and although this driver has a release https://github.com/kubernetes-sigs/aws-ebs-csi-driver/releases with support for CSI 0.3, that release has some bugs and users can still use that version for older k8s versions but they should be encouraged to use newer, more stable versions. - Interested on everyone else's thoughts on this.
  • Added double quotes to the secret.yaml file, this allows users to rely on EC2 instance roles and still run kubectl apply -f without having to remove that file.

What testing is done?
Locally ran e2e and sanity tests.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 7, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @dkoshkin. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2019
@coveralls
Copy link

coveralls commented Jan 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 337

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.931%
Totals Coverage Status
Change from base Build 323: 0.0%
Covered Lines: 602
Relevant Lines: 1182
💛 - Coveralls

@dkoshkin dkoshkin changed the title Csi images CSI image version and deployment manifests updates Jan 7, 2019
@leakingtapan
Copy link
Contributor

/retest

@dkoshkin dkoshkin force-pushed the csi-images branch 2 times, most recently from 9db3556 to b3bd25f Compare January 10, 2019 19:28
leakingtapan
leakingtapan requested changes Jan 12, 2019
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
deploy/kubernetes/latest/controller.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/latest/controller.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/latest/controller.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/latest/controller.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/latest/node.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/latest/node.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/latest/controller.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/latest/controller.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/latest/controller.yaml Outdated Show resolved Hide resolved
@leakingtapan
Copy link
Contributor

There are a lot of details here, will do another around of review

@dkoshkin dkoshkin force-pushed the csi-images branch 3 times, most recently from 9a23e39 to c043668 Compare January 14, 2019 21:17
@dkoshkin dkoshkin force-pushed the csi-images branch 2 times, most recently from 4faf09e to cbce7ce Compare January 15, 2019 14:52
@leakingtapan leakingtapan mentioned this pull request Jan 15, 2019
Closed
@dkoshkin dkoshkin force-pushed the csi-images branch 2 times, most recently from 63e0ca7 to 23aeccf Compare January 16, 2019 19:45
@dkoshkin
Copy link
Contributor Author

dkoshkin commented Jan 16, 2019 •
edited
Loading

Ok @leakingtapan I think this is ready for a final review.
New changes:

  • Added double quotes to the secret.yaml file, this allows users to rely on EC2 instance roles and still run kubectl apply -f without having to remove that file.

leakingtapan
leakingtapan reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@leakingtapan leakingtapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the quick turn around. Minor comment

docs/README.md Outdated Show resolved Hide resolved
@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkoshkin, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4cdb503 into kubernetes-sigs:master Jan 17, 2019
@dkoshkin dkoshkin deleted the csi-images branch March 5, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leakingtapan leakingtapan leakingtapan approved these changes

@d-nishi d-nishi Awaiting requested review from d-nishi

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@leakingtapan leakingtapan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update driver manifest for driver-registrar
4 participants
@dkoshkin @k8s-ci-robot @leakingtapan @coveralls