Helm Chart #169
Helm Chart #169
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shanesiebken If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XL
|
Hi @shanesiebken. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest |
|
@shanesiebken we are refactoring the manifest to align with recent upstream change. Please refer #171 This PR will need to be updated once the that is closed |
|
/cc @dkoshkin |
|
@leakingtapan: GitHub didn't allow me to request PR reviews from the following users: dkoshkin. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
No problem @leakingtapan. Sorry for the delay on this - I haven't had time to figure out how in the world to contact the team at CNCF, as my login / account on their site is totally messed up. |
|
@shanesiebken have you tried emailing: [email protected] |
|
I haven't - I'll try that first thing in the morning! Thanks for the suggestion! |
|
/retest |
|
@shanesiebken: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@leakingtapan Got my CLA signed! Not sure if there's anything more I need to do on here to get this PR to update, but let me know if there is. |
k8s-ci-robot
added
cncf-cla: yes
|
@shanesiebken Congrats! Our features have been involved a lot lately. Reviewing the code again for new changes |
| appVersion: "1.0" | ||
| description: A Helm chart for the AWS EBS CSI Driver (https://github.com/kubernetes-sigs/aws-ebs-csi-driver) | ||
| name: aws-ebs-csi-driver | ||
| version: 0.1.0 |
There was a problem hiding this comment.
Update to 0.2.0 since it is the latest.
| @@ -0,0 +1,166 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
we combined attacher and provisioner manifest few weeks back. Could you combine helm template as well?
There are a bunches of changes made along with the combine. I think its easier to create new helm templates referring the existing manifests
| node: | ||
| image: | ||
| repository: quay.io/k8scsi/driver-registrar | ||
| tag: v1.0-canary |
There was a problem hiding this comment.
Should use v1.0.1 for all the sidecars
|
/close @shanesiebken please reopen if you got a chance to finish the comment |
|
@leakingtapan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ckerfile.openshift.rhel7-baseimages-to-mach-ocp-build-data-config Bug 1878163: Updating Dockerfile.openshift.rhel7 baseimages to mach ocp-build-data config
Is this a bug fix or adding new feature?
New Feature.
Initial Helm Chart for driver components.
What is this PR about? / Why do we need it?
Starting point for work on #99
New PR because I'm fighting with git to get CLA signed on my account email address. Sorry for the churn 👎
What testing is done?
Deployed in staging cluster and confirmed output. More testing should be added.
More work should likely be done on this - but it captures a good portion of the "default" configuration of the driver components, as well as some of the more advanced functionality found in other charts - affinity, selectors, etc.