Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc of chart value additionalArgs #1697

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Add doc of chart value additionalArgs #1697

merged 1 commit into from
Aug 25, 2023

Conversation

zitudu
Copy link
Contributor

@zitudu zitudu commented Jul 20, 2023

Is this a bug fix or adding new feature?

Add doc of additionalArgs and mention --kube-api-burst and --kube-api-qps that #1666 requested.

What is this PR about? / Why do we need it?

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @zitudu!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @zitudu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from ConnorJC3 and rdpsin July 20, 2023 09:27
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 20, 2023
ConnorJC3
ConnorJC3 reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

docs/install.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 26, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 26, 2023
@zitudu zitudu force-pushed the doc/additional-args branch from a2d75c4 to a38257c Compare July 26, 2023 07:36
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 26, 2023
@zitudu
Copy link
Contributor Author

zitudu commented Jul 26, 2023

/retest

ConnorJC3
ConnorJC3 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (feel free to ignore the failing Windows test, that's due to a known ongoing issue)

cc @torredil @AndrewSirenko for secondary review

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@zitudu
Copy link
Contributor Author

zitudu commented Aug 7, 2023

ping @torredil @AndrewSirenko

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2023
@zitudu zitudu requested a review from torredil August 10, 2023 00:45
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2023
@ConnorJC3
Copy link
Contributor

Hi @zitudu sorry for the delay in review.

This PR looks good to me and I'm almost ready to merge it, but I need you to do two things first:

  1. Please rebase the PR and fix the merge conflicts
  2. Please squash your commits

After both of those are done, I can get this merged in. Thanks for contributing to the EBS CSI Driver!

@zitudu zitudu force-pushed the doc/additional-args branch from cf442d7 to f028423 Compare August 18, 2023 01:14
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2023
@zitudu zitudu requested a review from ConnorJC3 August 18, 2023 01:15
@zitudu zitudu force-pushed the doc/additional-args branch from f028423 to 80a8d1f Compare August 18, 2023 01:22
@zitudu
Copy link
Contributor Author

zitudu commented Aug 23, 2023

@ConnorJC3 Done!

Hi @zitudu sorry for the delay in review.

This PR looks good to me and I'm almost ready to merge it, but I need you to do two things first:

  1. Please rebase the PR and fix the merge conflicts
  2. Please squash your commits

After both of those are done, I can get this merged in. Thanks for contributing to the EBS CSI Driver!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2023
@zitudu zitudu force-pushed the doc/additional-args branch from 838e17e to 5ca5b9a Compare August 25, 2023 05:46
@zitudu
Copy link
Contributor Author

zitudu commented Aug 25, 2023

@ConnorJC3 Thank you for your review. I've made the changes you suggested and rebased them.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 25, 2023 •
edited
Loading

@zitudu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows 5ca5b9a link false /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ConnorJC3
Copy link
Contributor

/retest
/lgtm

/cc @torredil for approval

@k8s-ci-robot k8s-ci-robot requested a review from torredil August 25, 2023 14:44
@k8s-ci-robot
Copy link
Contributor

@ConnorJC3: GitHub didn't allow me to request PR reviews from the following users: for, approval.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/retest
/lgtm

/cc @torredil for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2023
torredil
torredil approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6ed7d06 into kubernetes-sigs:master Aug 25, 2023
@torredil torredil mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 approved these changes

@hanyuel hanyuel hanyuel approved these changes

@torredil torredil torredil approved these changes

@rdpsin rdpsin Awaiting requested review from rdpsin

Assignees

@ConnorJC3 ConnorJC3

@torredil torredil

@hanyuel hanyuel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zitudu @k8s-ci-robot @ConnorJC3 @torredil @hanyuel