Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for integration test #166

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

leakingtapan
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 294

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.352%

Totals Coverage Status
Change from base Build 292: 0.0%
Covered Lines: 572
Relevant Lines: 1136

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 3, 2019

Pull Request Test Coverage Report for Build 310

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.352%

Totals Coverage Status
Change from base Build 309: 0.0%
Covered Lines: 572
Relevant Lines: 1136

💛 - Coveralls

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor comments.

tests/integration/README.md Outdated Show resolved Hide resolved
tests/integration/README.md Outdated Show resolved Hide resolved
1. [AWS account](https://aws.amazon.com/account/) that has been [configured locally](https://docs.aws.amazon.com/cli/latest/userguide/cli-chap-configure.html)
### Requirements
1. AWS credential is [configured](https://docs.aws.amazon.com/cli/latest/userguide/cli-chap-configure.html)
1. Other requirements needed by aws-k8s-tester
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a link for aws-k8s-tester requirements would be nice (if there's any)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't any yet. Created an issue to track this: aws/aws-k8s-tester#32

tests/integration/README.md Outdated Show resolved Hide resolved
@leakingtapan leakingtapan force-pushed the update-doc branch 2 times, most recently from b8f0ecd to d9d55a7 Compare January 4, 2019 06:44
@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan leakingtapan merged commit e048c86 into kubernetes-sigs:master Jan 7, 2019
@leakingtapan leakingtapan deleted the update-doc branch February 1, 2019 18:54
huffmanca pushed a commit to huffmanca/aws-ebs-csi-driver that referenced this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants