Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test integration with prow #162

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Test integration with prow #162

merged 1 commit into from
Dec 28, 2018

Conversation

kschumy
Copy link

@kschumy kschumy commented Dec 26, 2018 •
edited
Loading

Is this a bug fix or adding new feature?
Feature

What is this PR about? / Why do we need it?
See issue #36
make test-integration uses PULL_NUMBER for prow and a flag for vpc-id

What testing is done?
Testing locally

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 26, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 26, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @kschumy. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 26, 2018
@coveralls
Copy link

coveralls commented Dec 26, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 291

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.352%
Totals Coverage Status
Change from base Build 284: 0.0%
Covered Lines: 572
Relevant Lines: 1136
💛 - Coveralls

@kschumy
Copy link
Author

kschumy commented Dec 26, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 26, 2018
@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 26, 2018
@kschumy kschumy force-pushed the test-integration-with-prow branch from f1a725f to d7f1c8f Compare December 27, 2018 00:29
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 27, 2018
@gyuho
Copy link
Member

gyuho commented Dec 27, 2018

/lgtm

Thanks!

/cc @leakingtapan This will let you specify your own VPC when run locally. If not configured, it will use the default VPC ID, pre-created in our test account.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2018
@gyuho
Copy link
Member

gyuho commented Dec 27, 2018

@leakingtapan

AWS_K8S_TESTER_VPC_ID="" make test-integration

will create a new VPC in your AWS account, and delete on test complete.

@kschumy kschumy mentioned this pull request Dec 27, 2018
Closed
5 tasks
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2018
leakingtapan
leakingtapan reviewed Dec 27, 2018
View reviewed changes
Copy link
Contributor

@leakingtapan leakingtapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see prow job is running, is it running yet?

Makefile Outdated
@@ -41,7 +54,7 @@ test-sanity:
test-integration:
curl -L ${AWS_K8S_TESTER_DOWNLOAD_URL} -o ${AWS_K8S_TESTER_PATH}
chmod +x ${AWS_K8S_TESTER_PATH}
aws-k8s-tester csi test integration --terminate-on-exit=true --csi=master --timeout=20m
aws-k8s-tester csi test integration --terminate-on-exit=true --timeout=20m ${CSI_FLAG} ${VPC_ID_FLAG}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be ${AWS_K8S_TESTER_PATH} csi test integration --terminate-on-exit=true --timeout=20m ${CSI_FLAG} ${VPC_ID_FLAG} ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

leakingtapan
leakingtapan reviewed Dec 27, 2018
View reviewed changes
tests/integration/README.md
@@ -14,6 +14,11 @@ Must satisfy also the requirements for `aws-ebs-csi-driver`
make test-integration
```

#### Overriding Defaults
- The master branch of `aws-ebs-csi-driver` is used by default. To run using a pull request for `aws-ebs-csi-driver`, set `PULL_NUMBER` as an environment variable with a value equal to the pull request number.
Copy link
Contributor

@leakingtapan leakingtapan Dec 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is it possible to run the integ test against local changes? It feels to me that in local development, test for local changes will be very useful. We don't have to do it here. But want to know what's our thoughts on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's doable.

  1. create a PR with your local change
  2. pass that PULL_NUMBER environmental variable to make test-integration

In the future, we can support specifying git origin and branch name, so we can test it without creating a PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. create a PR with your local change
  2. pass that PULL_NUMBER environmental variable to make test-integration

Confirming this works locally

@kschumy kschumy force-pushed the test-integration-with-prow branch from d7f1c8f to 1fa6fb4 Compare December 27, 2018 20:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2018
@gyuho
Copy link
Member

gyuho commented Dec 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2018
@gyuho
Copy link
Member

gyuho commented Dec 27, 2018

@leakingtapan

Didn't see prow job is running, is it running yet?

This PR has to be merged first.
And we can merge kubernetes/test-infra#10556 to run this :)

@leakingtapan
Copy link
Contributor

/lgtm

Please rebase the commits then I will approve

@kschumy kschumy force-pushed the test-integration-with-prow branch from 1fa6fb4 to 4a6844e Compare December 28, 2018 00:09
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2018
@kschumy
Copy link
Author

kschumy commented Dec 28, 2018

@leakingtapan

Please rebase the commits then I will approve

done!

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kschumy, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4f5f8e4 into kubernetes-sigs:master Dec 28, 2018
This was referenced Dec 31, 2018
Closed
Closed
Merged
huffmanca pushed a commit to huffmanca/aws-ebs-csi-driver that referenced this pull request Sep 3, 2020
@openshift-merge-robot
Merge pull request kubernetes-sigs#162 from bertinatto/fix-vendor
df0358a 
Bug 1872244: Update vendor/ directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leakingtapan leakingtapan leakingtapan left review comments

@gyuho gyuho gyuho left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees

@leakingtapan leakingtapan

@gyuho gyuho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kschumy @k8s-ci-robot @coveralls @leakingtapan @gyuho