-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to append extra string to user agent #1599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, but needs some fixes
Also, please change commit/PR name to something like "Add option to append extra string to user agent"
0be5e32
to
4ec1535
Compare
Signed-off-by: Eddie Torres <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@torredil: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Is this a bug fix or adding new feature?
New feature
What is this PR about? / Why do we need it?
Add an option to set a custom user agent.
It is recommended as a best practice to include a User-Agent header with every request. Doing this helps to more effectively diagnose and fix problems.
What testing is done?
Manual/CI/Unit Testing