-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix staging / unmounting volume operations on Windows #1526
Fix staging / unmounting volume operations on Windows #1526
Conversation
f596067
to
205c734
Compare
- `GetDeviceNameFromMount` now returns the disk number for a mount path on Windows - Cleanup the stage path via Rmdir in `proxyMounter.Unmount()` - Remove unnecessary call to `proxyMounter.WriteVolumeCache()` when unpublishing a volume - Return a nil error in `GetDeviceNameFromMount` if the target path does not exist Signed-off-by: Eddie Torres <[email protected]>
205c734
to
e538f66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtxu, hanyuel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
What is this PR about?
This PR fixes several bugs uncovered by running the external e2e tests on Windows. It will allow us to run the tests in parallel and should land before #1521.
GetDeviceNameFromMount
now returns the disk number for a mount path on Windows.Rmdir
inproxyMounter.Unmount()
before offlining the disk.proxyMounter.WriteVolumeCache()
when unpublishing a volume from the node.GetDeviceNameFromMount
if the target path does not exist, per the CSI spec: If the volume corresponding to the volume_id is not staged to the staging_target_path, the Plugin MUST reply 0 OK.Why do we need it?
To fix the following issues:
What testing is done?