Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always log driver information #1525

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

torredil
Copy link
Member

@torredil torredil commented Mar 9, 2023

What is this PR about? / Why do we need it?

  • This information helps with debugging. The current default is --v=2 which unfortunately does not log this information.

What testing is done?

$ kubectl describe pod ebs-csi-controller-5b7b77b787-d4ml5 -n kube-system
Name:                 ebs-csi-controller-5b7b77b787-d4ml5
Namespace:            kube-system
Containers:
  ebs-plugin:
...
    Args:
      controller
      --endpoint=$(CSI_ENDPOINT)
      --logging-format=text
      --v=0

$ kubectl logs ebs-csi-controller-5b7b77b787-d4ml5 -n kube-system -c ebs-plugin

I0309 16:01:08.462742       1 driver.go:73] "Driver Information" Driver="ebs.csi.aws.com" Version="v1.16.0"

Signed-off-by: Eddie Torres <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot requested review from ConnorJC3 and rdpsin March 9, 2023 18:17
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2023
@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit b184b42 into kubernetes-sigs:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants