Don't trim device prefix for existing volumes in DeviceManager #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
ConnorJC3
force-pushed
the
fix-manually-attached
branch
from
cc7e528 to
8ec5252
Compare
k8s-ci-robot
added
size/S
ConnorJC3
force-pushed
the
fix-manually-attached
branch
from
8ec5252 to
5afd743
Compare
If a volume is (already) mounted at /dev/sdX, DM will trim the prefix and claim the volume should be mounted at /dev/xvdX - this causes the driver to get stuck in an infinite loop waiting for the volume to be attached to the wrong location. This bug commonly is triggered by manually mounting a volume using the AWS console, because it uses the prefix /dev/sdX by default. Signed-off-by: Connor Catlett <[email protected]>
ConnorJC3
force-pushed
the
fix-manually-attached
branch
from
5afd743 to
f4a222a
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Superceded by #1518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a volume is (already) mounted at /dev/sdX, DM will trim the prefix and claim the volume should be mounted at /dev/xvdX - this causes the driver to get stuck in an infinite loop waiting for the volume to be attached to the wrong location. This bug commonly is triggered by manually mounting a volume using the AWS console, because it uses the prefix /dev/sdX by default.
Signed-off-by: Connor Catlett [email protected]