Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI; Upgrade golangci-lint #1505

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

torredil
Copy link
Member

@torredil torredil commented Feb 8, 2023

What is this PR about? / Why do we need it?

What testing is done?

$ docker run -it --rm --entrypoint /bin/bash gcr.io/k8s-staging-test-infra/kubekins-e2e:v20230207-192d5afee3-master
$ export GOPROXY=direct
$ git clone https://github.com/torredil/aws-ebs-csi-driver.git && cd aws-ebs-csi-driver && git checkout fix-ci
$ make verify

No issue found
echo "verifying and linting files ..."
verifying and linting files ...
./hack/verify-all
Verifying gofmt
No issue found
Verifying govet
Done
WARN [linters_context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649.
Repo uses 'go mod'.
+ env GO111MODULE=on go mod tidy
Go dependencies up-to-date.
echo "Congratulations! All Go source files have been linted."
Congratulations! All Go source files have been linted.

Signed-off-by: Eddie Torres [email protected]

* endpoints.Ec2ServiceID is deprecated: Use client package's EndpointsID value instead of ServiceIDs.
* rand.Seed is deprecated; use rand.New(NewSource(seed)).

Signed-off-by: Eddie Torres <[email protected]>
@torredil torredil requested review from ConnorJC3 and rdpsin February 8, 2023 19:15
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2023
@rdpsin
Copy link
Contributor

rdpsin commented Feb 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit b4f67bd into kubernetes-sigs:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants