Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1465

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

torredil
Copy link
Member

What is this PR about? / Why do we need it?

  • Update compatibility information.

Signed-off-by: Eddie Torres [email protected]

@torredil torredil requested review from ConnorJC3 and rdpsin December 27, 2022 17:14
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Dec 27, 2022

Can you update the commit description and message to more accurately reflect what's going on in the PR? (Update README.md seems very vague).

@rdpsin
Copy link
Contributor

rdpsin commented Dec 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2022
Consolidate compatibility information and clarify release cadence

Signed-off-by: Eddie Torres <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Dec 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2022
@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit aba27bb into kubernetes-sigs:master Dec 29, 2022
@rob-howie-depop
Copy link

You missed a reference to the "compatibility matrix" here:
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/install.md#deploy-driver

I just spent an hour reading through AWS pages and this repo, before realising that someone might have deleted it!

@torredil
Copy link
Member Author

@rob-howie-depop Thanks for catching that! #1484

@chrisRedwine
Copy link

I'm curious why this was removed. The current docs just state that the AWS EBS CSI Driver is compatible with all versions supported by K8s and/or EKS - but surely, for example, 0.1.0 wouldn't work with K8s 1.30 - so it's unclear to me what this actually means.

@ConnorJC3
Copy link
Contributor

@chrisRedwine we only test/maintain compatibility for supported versions (i.e. as of writing, the most recent two minor versions). As such, our README accurately reflects this: https://github.com/kubernetes-sigs/aws-ebs-csi-driver?tab=readme-ov-file#compatibility

Older versions may work but we don't test their compatibility and thus don't publish information about it. Additionally, such old versions are not supported and very likely are missing bugfixes, dependency updates to address CVEs, and other similar important changes, so we would strongly recommend sticking with the latest stable version if you are installing/upgrading the EBS CSI Driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants