Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.md & options.md docs #1458

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

torredil
Copy link
Member

What is this PR about? / Why do we need it?

  • Update docs/install.md - The policy was updated in Update example policy #1450 which introduced a new condition for managing volumes created by the in-tree driver. The removed section is no longer relevant. See Update example policy #1450 (comment)
  • Update docs/options.md - Sneaking this change in here as well, the current description for the endpoint driver option is not accurate.

Signed-off-by: Eddie Torres [email protected]

@torredil torredil requested review from ConnorJC3 and rdpsin December 13, 2022 19:42
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot requested a review from gtxu December 13, 2022 19:42
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 13, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Dec 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Dec 16, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdpsin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 144df7b into kubernetes-sigs:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants