Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test-helm-chart target to Makefile to test Helm chart upgrades #1454

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Add test-helm-chart target to Makefile to test Helm chart upgrades #1454

merged 1 commit into from
Jan 6, 2023

Conversation

torredil
Copy link
Member

@torredil torredil commented Nov 21, 2022 •
edited
Loading

What is this PR about? / Why do we need it?

What testing is done?

  • Manual
  • CI
  1. Pull changes locally.
  2. Run CLUSTER_TYPE=kops KOPS_STATE_FILE="s3://devcluster-state-e2e" make test-helm-chart

Signed-off-by: Eddie Torres [email protected]

@torredil torredil requested review from ConnorJC3 and gtxu November 21, 2022 21:43
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 21, 2022
@torredil torredil force-pushed the chart-testing branch 2 times, most recently from 15592e3 to 662cbf8 Compare November 22, 2022 14:31
@torredil torredil marked this pull request as ready for review November 22, 2022 14:31
@torredil
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 22, 2022
ConnorJC3
ConnorJC3 reviewed Nov 23, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@rdpsin rdpsin mentioned this pull request Dec 19, 2022
Merged
ConnorJC3
ConnorJC3 requested changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be updated with a runthrough with the latest kubekins image before it is accepted.

Makefile Outdated Show resolved Hide resolved
charts/chart_schema.yaml Outdated Show resolved Hide resolved
charts/config.yaml Outdated Show resolved Hide resolved
charts/lintconf.yaml Outdated Show resolved Hide resolved
hack/e2e/chart-testing.sh Outdated Show resolved Hide resolved
hack/e2e/chart-testing.sh Outdated Show resolved Hide resolved
hack/e2e/run.sh Outdated Show resolved Hide resolved
hack/e2e/run.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 21, 2022
@torredil
Copy link
Member Author

Attaching a run-through with the latest kubekins image here with this revision:
log.txt

ConnorJC3
ConnorJC3 reviewed Jan 6, 2023
View reviewed changes
tests/ct-lintconfig.yaml Outdated Show resolved Hide resolved
@torredil torredil changed the title Add test-helm-chart target to Makefile to lint/test Helm chart upgrades Add test-helm-chart target to Makefile to test Helm chart upgrades Jan 6, 2023
@ConnorJC3
Copy link
Contributor

Commit 8eed2185d3c5f0086f4e3726535ae8c1222cf229 (latest as of commenting) passes with latest kubekins image:

Deleted cluster: "test-cluster-15561.k8s.local"
###
## OVERALL_TEST_PASSED: 0
#
###
## SUCCESS!
#
root@483133e2920e:/workspace/aws-ebs-csi-driver# git rev-parse HEAD
8eed2185d3c5f0086f4e3726535ae8c1222cf229

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit cd21a03 into kubernetes-sigs:master Jan 6, 2023
@torredil torredil mentioned this pull request Jan 9, 2023
Merged
@robinkb robinkb mentioned this pull request Jan 12, 2023
Closed
@cartermckinnon cartermckinnon mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 approved these changes

@gtxu gtxu Awaiting requested review from gtxu

Assignees

@ConnorJC3 ConnorJC3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torredil @k8s-ci-robot @ConnorJC3