-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Expose volumes and volumeMounts for the ebs-csi-controller deployment #1436
helm: Expose volumes and volumeMounts for the ebs-csi-controller deployment #1436
Conversation
Hi @cnmcavoy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d142ff7
to
47b1d95
Compare
/ok-to-test |
47b1d95
to
a292cb0
Compare
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm Thanks for the contribution @cnmcavoy ! |
Is this a bug fix or adding new feature?
Feature.
What is this PR about? / Why do we need it?
Allows users who wish to integrate the controller with IRSA authentication manually (i.e not using the https://github.com/aws/amazon-eks-pod-identity-webhook) to configure the controller with the correct mounts for authentication. For example:
What testing is done?
Helm template verification.