-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move the default controller tolerations in the helm chart values #1427
Conversation
|
Welcome @Linutux42! |
Hi @Linutux42. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This seems to have caused helm to reorder the tolerations for some reason ¯\_(ツ)_/¯ @Linutux42 can you run |
/retest |
/lgtm |
/lgtm |
@torredil I've squashed my commits into a single one as requested :) edit: Oops, I thought you needed me to do the squash instead of letting the github merge process do it on its own :( |
You actually do, because the bot won't squash them when it merges stuff in. /lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is this PR about? / Why do we need it?
Give more flexibility to the helm chart users for the csi-controller tolerations.
The default values remains unchanged and the default behavior is also unchanged.
However, one with different needs regarding those tolerations can modify them at will.