Add serviceMonitor.labels parameter

[torredil]

What is this PR about? / Why do we need it?

• Allow modifying labels for the ServiceMonitor object.
• Parameterize the hardcoded namespace in metrics.yaml.
• Address Add enableMetrics configuration #1380 (comment)
• closes [helm] Don't check capabilities when enableMetrics: true #1420

What testing is done?

• Rendered Helm chart.

Signed-off-by: Eddie Torres [email protected]

[ConnorJC3]

/hold for other reviews
/lgtm

[gtxu]

/lgtm

[torredil]

Addressing #1420 in this PR.

• .Values.controller.serviceMonitor.forceEnable = true & CRDs not installed.

$ helm template ./ | grep -A 20 "monitoring.coreos.com/v1"

apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: ebs-csi-controller
  namespace: default
  labels:
    app: ebs-csi-controller
    release: prometheus
spec:
  selector:
    matchLabels:
      app: ebs-csi-controller
  namespaceSelector:
    matchNames:
      - default
  endpoints:
    - targetPort: 3301
      path: /metrics
      interval: 15s

• .Values.controller.serviceMonitor.forceEnable = false & CRDs not installed.

$ helm template ./ | grep -A 20 "monitoring.coreos.com/v1"

[ConnorJC3]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, gtxu, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ConnorJC3,gtxu,torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ConnorJC3]

/remove-hold